TemplateProcessor: Added a method to replace multiple XML blocks #2741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Often you will need to replace variables with a new XML block. Currently, there is already a
replaceXmlBlockmethod that replaces only the first occurrence of a variable. To replace all of them, you will need to call this method again. This makes the code unreadable, and sometimes there is a chance that the number of these variables is determined dynamically (in my case it is). I have added a new public methodreplaceMultipleXmlBlocks, which uses the new protected methodfindAllContainingXmlBlockForMacroand solves this problem. I would be glad if my contribution is accepted!Checklist: