feat: remove wifi or workspace conditional (#26)

* bugfix: handle variable number of listing detail rows Signed-off-by: Patrick Erichsen <patrick.a.erichsen@gmail.com> * feat: add comment to Signed-off-by: Patrick Erichsen <patrick.a.erichsen@gmail.com> * feat: remove wifi or workspace conditional Signed-off-by: Patrick Erichsen <patrick.a.erichsen@gmail.com>
Patrick-Erichsen · Nov 7, 2021 · 02c1ab5 · 02c1ab5
1 parent 132944f
commit 02c1ab5
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 69 deletions.
diff --git a/assets/manifest.json b/assets/manifest.json
@@ -2,7 +2,7 @@
   "name": "Offie - Airbnb Wifi Reviews",
   "description": "View Wifi and workspace info from the Airbnb search results page.",
   "manifest_version": 3,
-  "version": "0.0.7",
+  "version": "0.0.8",
   "icons": {
     "16": "img/offie-logo-16.png",
     "48": "img/offie-logo-48.png",

diff --git a/src/content/App.tsx b/src/content/App.tsx
@@ -1,27 +1,19 @@
 import { useState } from 'react';
 import { useUrlChangeChrome } from './hooks/useUrlChangeChrome';
 import { OffiePortals } from './components/OffiePortals';
-import { hasWifiOrWorkspaceFilter, isHomesSearchPage } from './utils';
+import { isHomesSearchPage } from './utils';
 import './App.css';
 
 export const App = (): JSX.Element | null => {
     const [isVisible, setIsVisible] = useState<boolean>(false);
 
     useUrlChangeChrome((newUrl) => {
         /**
-         * If a user is not on the search page, ignore the update
+         * Only render if on the homes search page
          */
-        if (isHomesSearchPage(newUrl)) {
-            const newIsVisible = hasWifiOrWorkspaceFilter(newUrl);
-
-            setIsVisible(newIsVisible);
-        }
+        setIsVisible(isHomesSearchPage(newUrl));
     });
 
-    /**
-     * Only display our portals if the `Wifi` or
-     * `Dedicated workspace` filters are active
-     */
     if (!isVisible) {
         return null;
     }

diff --git a/src/content/utils/__tests__/airbnb.spec.ts b/src/content/utils/__tests__/airbnb.spec.ts
@@ -85,26 +85,6 @@ describe('airbnb.ts', () => {
         });
     });
 
-    describe('hasWifiOrWorkspaceFilter()', () => {
-        it('returns true is the url string has the wifi filter key', () => {
-            const mockUrl = `https://www.airbnb.com/s/Downtown--Honolulu--HI--United-States/homes?amenities%5B%5D=${airbnb.WIFI_FILTER_KEY_NUM}`;
-
-            expect(airbnb.hasWifiOrWorkspaceFilter(mockUrl)).toBe(true);
-        });
-
-        it('returns true is the url string has the dedicated workspace filter key', () => {
-            const mockUrl = `https://www.airbnb.com/s/Downtown--Honolulu--HI--United-States/homes?amenities%5B%5D=${airbnb.DEDICATED_WORKSPACE_FILTER_KEY_NUM}`;
-
-            expect(airbnb.hasWifiOrWorkspaceFilter(mockUrl)).toBe(true);
-        });
-
-        it('returns false is the url string does not have the dedicated workspace or wifi filter keys', () => {
-            const mockUrl = `https://www.airbnb.com/s/Downtown--Honolulu--HI--United-States/homes`;
-
-            expect(airbnb.hasWifiOrWorkspaceFilter(mockUrl)).toBe(false);
-        });
-    });
-
     describe('isHomesSearchPage()', () => {
         it('returns false if not a homes search page', () => {
             expect(

diff --git a/src/content/utils/airbnb.ts b/src/content/utils/airbnb.ts
@@ -1,6 +1,5 @@
 import * as qs from 'qs';
 import { rollbar } from '../../utils/rollbar';
-import { getParsedUrlSearch } from './misc';
 
 export interface AirbnbFilterKeyMap {
     [key: number]: string;
@@ -29,6 +28,8 @@ export const WIFI_FILTER_KEY_NUM = 4;
 
 export const DEDICATED_WORKSPACE_FILTER_KEY_NUM = 47;
 
+export const HOMES_SEARCH_ROUTE = '/homes';
+
 /**
  * What is `kg_and_tags`? E.g. `Beachfront`, `Ski-in/ski-out` filters
  */
@@ -266,43 +267,8 @@ export const getMappedSearchFilters = (
     }, {});
 };
 
-/**
- * Check if an Airbnb search URL contains a filter for `Wifi` or
- * `Dedicated workspaces`.
- */
-export const hasWifiOrWorkspaceFilter = (urlStr: string): boolean => {
-    const search = getParsedUrlSearch(urlStr);
-    const filters = getMappedSearchFilters(search);
-
-    const { amenities } = filters;
-
-    // If a user has not applied any filters yet, return
-    if (!amenities) {
-        return false;
-    }
-
-    // We expect the amenities URL param to be an array type, so log an error
-    // if it is not an array
-    if (!Array.isArray(amenities)) {
-        rollbar.warning(
-            `Expected the amenities key to an array, but found: ${typeof amenities}`
-        );
-
-        return false;
-    }
-
-    const hasWifiFilter = amenities.includes(
-        FILTERABLE_AMENITY_ID_TO_STR[WIFI_FILTER_KEY_NUM]
-    );
-    const hasDedicatedWorkspaceFilter = amenities.includes(
-        FILTERABLE_AMENITY_ID_TO_STR[DEDICATED_WORKSPACE_FILTER_KEY_NUM]
-    );
-
-    return hasWifiFilter || hasDedicatedWorkspaceFilter;
-};
-
 export const isHomesSearchPage = (url: string): boolean => {
     const { pathname } = new URL(url);
 
-    return pathname.includes('/homes');
+    return pathname.includes(HOMES_SEARCH_ROUTE);
 };