Skip to content

Minor corrections to new period finding demo #1357

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Apr 29, 2025

Conversation

mariaschuld
Copy link
Contributor

Fixes some minor issues raised by readers.

Copy link

👋 Hey, looks like you've updated some demos!

🐘 Don't forget to update the dateOfLastModification in the associated metadata files so your changes are reflected in Glass Onion (search and recommendations).

Please hide this comment once the field(s) are updated. Thanks!

@mariaschuld mariaschuld requested review from dwierichs, justinpickering and alvaro-at-xanadu and removed request for justinpickering April 29, 2025 07:25
@mariaschuld
Copy link
Contributor Author

@alvaro-at-xanadu do we update the modification date if it's just a few typos?

Copy link

github-actions bot commented Apr 29, 2025

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1357
  • Deployment SHA: 1952a89b378a2a6b624ab04c0b3ea72742e38e20
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @mariaschuld 🙏 💯
Now I actually understood why there are seven qubits, I got it wrong before!
Up to the question about modification date, it looks good to me 👍

@alvaro-at-xanadu
Copy link
Collaborator

@alvaro-at-xanadu do we update the modification date if it's just a few typos?

Hi @mariaschuld Yes, this is the best practice even if corrections are minor

@mariaschuld mariaschuld merged commit 9ff85b9 into master Apr 29, 2025
14 checks passed
@mariaschuld mariaschuld deleted the corrections-period-finding branch April 29, 2025 16:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants