PS-9609: locate_secrets_* operations added to kmippp #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukin-oleksiy
force-pushed
the
PS-9609-add_locate_secret_data
branch
2 times, most recently
from
014db87 to
c085c30
Compare
lukin-oleksiy
changed the title
https://perconadev.atlassian.net/browse/PS-9609 op_locate_secrets_by_group() and op_all_secrets() operationos added to kmippp library to be able to load audit log encryption passwords into component_keyring_kmip cache. Version bumped to 0.3.2
lukin-oleksiy
force-pushed
the
PS-9609-add_locate_secret_data
branch
from
c085c30 to
5c2e392
Compare
ktrushin
reviewed
Apr 8, 2025
Comment on lines
+20
to
+21
| const std::string group = argv[6]!=nullptr? argv[6] : "TestGroup"; | ||
| auto keys = ctx.op_locate_secrets_by_group (group); |
There was a problem hiding this comment.
It seems these two lines have excessive indent of one space.
|
|
||
| while (upto < all) | ||
| { | ||
| int result = kmip_bio_locate (bio_, a, 2, &locate_result, 16, upto); |
There was a problem hiding this comment.
I would use a named constant (e.g. attribute_count) instead of hardcoded 2.
| ta.attribute_count = ARRAY_LENGTH (a); | ||
|
|
||
| int upto = 0; | ||
| int all = 1; // TMP |
Comment on lines
+425
to
+437
| if (locate_result.located_items != 0) | ||
| { | ||
| all = locate_result.located_items; // shouldn't change after its != 1 | ||
| } | ||
| else | ||
| { | ||
| // Dummy server sometimes returns 0 for located_items | ||
| all += locate_result.ids_size; | ||
| if (locate_result.ids_size == 0) | ||
| { | ||
| --all; | ||
| } | ||
| } |
There was a problem hiding this comment.
The logic with all, located_items and ids_size isn't crystal clear. Probably , a detailed comment would be helpful.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
op_locate_secrets_by_group() and op_all_secrets() operations added to kmippp library to be able to load audit log encryption passwords into component_keyring_kmip cache. Version bumped to 0.3.2