Oplog/Resolver/Resolver.py: De-duplicating code closing the pool #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The close() function is already being called at the end of the stage. The same code present in wait() is needless duplication. This commit removes the duplicated code from wait() and a slight change in the conditions in close().
timvaillancourt
approved these changes
Oct 8, 2018
|
Thanks @corey-hammerton! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The close() function is already being called at the end of the stage. The same code present in wait() is needless duplication. This commit removes the duplicated code from wait() and a slight change in the conditions in close().
It is unknown if this contributes to #277 but at the very least this reduces the attack surface.