PMM-13805 Added support to setup PMM3 with PPG & PGSM from PPG testing repos. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g repos.
*For PPG we have following repo structure available, and this commit makes sure we can use minor version testing or release repo.
Release
-Major: like ppg-16
-Minor: like ppg-16.8
Testing
-Minor: like ppg-16.8
-There is no MAJOR repo under testing repo
*For using Minor Version testing repo repo, following ENV variable should be used.
export PDPGSQL_VERSION=15 # Major Verion Only
export PPG_REPO_VERSION=15.12
export PPG_REPO_TYPE=testing
python pmm-framework.py --database PDPGSQL --verbose
*For using Minor Version release repo repo, following ENV variable should be used.
export PDPGSQL_VERSION=15 # Major Verion Only
export PPG_REPO_VERSION=15.12
export PPG_REPO_TYPE=release
python pmm-framework.py --database PDPGSQL --verbose
*Already existing use case with Release repo will work as before.
export PDPGSQL_VERSION=15 # Major Verion Only
python pmm-framework.py --database PDPGSQL --verbose
Naeem-Akhter
requested review from
yurkovychv,
puneet0191,
olexandr-havryliak and
sandraromanchenko
as code owners
puneet0191
approved these changes
Mar 3, 2025
saikumar-vs
reviewed
Mar 4, 2025
| @@ -17,6 +17,8 @@ | |||
| use_socket: "{{ lookup('vars', 'extra_pdpgsql_version', default=lookup('env','USE_SOCKET') | default('', true) ) }}" | |||
| pdpgsql_pgsm_port: "{{ lookup('vars', 'extra_pdpgsql_port', default=lookup('env','PDPGSQL_PGSM_PORT') | default(5447, true) ) }}" | |||
| distribution: "{{ lookup('vars', 'extra_pdpgsql_distribution', default=lookup('env','DISTRIBUTION') | default('PPG', true) ) }}" | |||
| ppg_repo_version: "{{ lookup('vars', 'extra_ppg_repo_version', default=lookup('env','PPG_REPO_VERSION') | default('', true) ) }}" | |||
There was a problem hiding this comment.
Thanks for the work on this Naeem,
Can we retain env variable PPG_VERSION, instead of PPG_REPO_VERSION, this will allow the wrapper(python) script to also work, with your changes.
Also can you please assign PPG_REPO_VERSION, default as "testing" so that we ensure if nothing is passed from the wrapper we always consider testing repo, instead of release, if thats fine by you.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13805 Added support to setup PMM3 with PPG & PGSM from PPG testing repos.
*For PPG we have following repo structure available, and this commit makes sure we can use minor version testing or release repo.
Release
-Major: like ppg-16
-Minor: like ppg-16.8
Testing
-Minor: like ppg-16.8
-There is no MAJOR repo under testing repo
*For using Minor Version testing repo, following ENV variable should be used.
export PDPGSQL_VERSION=15 # Major Verion Only
export PPG_REPO_VERSION=15.12
export PPG_REPO_TYPE=testing
python pmm-framework.py --database PDPGSQL --verbose
*For using Minor Version release repo, following ENV variable should be used.
export PDPGSQL_VERSION=15 # Major Verion Only
export PPG_REPO_VERSION=15.12
export PPG_REPO_TYPE=release
python pmm-framework.py --database PDPGSQL --verbose
*Already existing use case with Release repo will work as before.
export PDPGSQL_VERSION=15 # Major Verion Only
python pmm-framework.py --database PDPGSQL --verbose