Skip to content

Feat/add visualizer #47

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Draft
wants to merge 42 commits into
base: main
Choose a base branch
from
Draft

Feat/add visualizer #47

wants to merge 42 commits into from
+858 −3

Conversation

Thijss
Copy link
Contributor

@Thijss Thijss commented Mar 20, 2025 •
edited
Loading

This PR adds (optional) visualizing functionality to PGM-DS 🚀

ToDo:

  • > 80% test coverage
  • some linting issues
  • add graph legend (optional)
  • make the search form prettier
  • switch graph layouts in frontend
  • add documentation below to read-the-docs

(docs/visualizer.md)

@Thijss Thijss mentioned this pull request Mar 25, 2025
Open
Thijss and others added 15 commits March 30, 2025 14:15
@Thijss
adjust view height
fb7ff04
@Thijss
cleanup
403bd30
@Thijss
remove uv.lock
d47df1e
@Thijss
add REUSE Compliance
5e8475d
@Thijss
make visualize import optional and
32a00d8 
DCO Remediation Commit for Thijs Baaijen <13253091+Thijss@users.noreply.github.com>

I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 8523654
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 5426cc8
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 11b422a
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 735e2e4
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: e58a463
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: f3041a7
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 8c460b3
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 32502fc
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 0520977
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: fb3aee2
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 78fd55f
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: b19ffa8
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: ff38bb2
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: dae8686
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: fb7ff04
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 403bd30
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: d47df1e
I, Thijs Baaijen <13253091+Thijss@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 5e8475d

Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
move visualizer import
e5cb443 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
cleanup code
55389f3 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
install visualizer deps in CI
40e9761 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
Add parser tests
10ba51c 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
Add REUSE compliance
c498ffc 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
Install visualizer in CI
678a9ee 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
cleanup
92597c0 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
add visualizer dependencies to 'dev' group too
2cbcd3a 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
move CoordinatedNodeArray
422d76f 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
Add documentation
c15a384 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Thijss added 5 commits March 31, 2025 23:56
@Thijss
Add port parameter
f33bd47 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
move vis-deps to correct group
63069de 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
Add reuse
1f1f0b0 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
rename main.py to app.py
c4c509a 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
add layout test
bf563e4 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
jaapschoutenalliander
jaapschoutenalliander reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@jaapschoutenalliander jaapschoutenalliander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

Thijss and others added 8 commits April 18, 2025 11:39
@Thijss
exclude visualizer from coverage
bff8c2b 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
Update visualizer docs with disclaimer
3bf3f1b 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
re-enable visualizer tests
f26873e 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
Update docs
a4e6585 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss @jaapschoutenalliander
Update pyproject.toml
985da8d 
Co-authored-by: Jaap Schouten <58551444+jaapschoutenalliander@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
Add basic test for get_app_layout
cf74704 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss
Merge remote-tracking branch 'origin/feat/add-visualizer' into feat/a…
5d583b2 
…dd-visualizer
@Thijss
clenaup
e896064 
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
74.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jaapschoutenalliander jaapschoutenalliander jaapschoutenalliander left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thijss @jaapschoutenalliander