-
Notifications
You must be signed in to change notification settings - Fork 43
(SCHEMA) Update schemas for v3.1.0 release #890
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Draft
michaeltlombardi
wants to merge
9
commits into
PowerShell:main
Choose a base branch
from
michaeltlombardi:schema/main/v3.1.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
(SCHEMA) Update schemas for v3.1.0 release #890
michaeltlombardi
wants to merge
9
commits into
PowerShell:main
from
michaeltlombardi:schema/main/v3.1.0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
828ae59
to
bd559a5
Compare
SteveL-MSFT
reviewed
Jun 26, 2025
SteveL-MSFT
requested changes
Jun 26, 2025
theJasonHelmick
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Steve's comments - LGTM
3 tasks
Prior to this change, the requirements for various resource kinds was incomplete and inaccurate. This change updates the `allOf` applicator to correctly define required and forbidden properties for each resource kind.
bd559a5
to
aa026b9
Compare
SteveL-MSFT
requested changes
Jun 27, 2025
- Microsoft.Windows.Appx/Discover | ||
|
||
type: string | ||
pattern: ^\w+(\.\w+){0,2}\/\w+$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was brought up in an issue, do we really want to enforce only two dots?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This changeset includes:
v3.0.1
andv3.0.2
releases. Neither of these releases required any schema changes except to extend the sets of valid schema URIs for resource manifests and configuration documents.v3.1.0
release. This release required changes to support the addition of theexporter
resource kind (and associated required output for the Export operation) and the addition of the extension manifest and expected output for the Discover extension operation.Until the changes for v3.1.0 are reviewed, I haven't regenerated the schemas to reduce the noise in the commits. After those changes are reviewed, I'll regenerate the schemas for v3.1.0.
PR Context