-
Notifications
You must be signed in to change notification settings - Fork 53
DICOM Seg Writer Op Tag Writing Updates #533
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
DICOM Seg Writer Op Tag Writing Updates #533
Conversation
Signed-off-by: bluna301 <luna.bryanr@gmail.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for making the AI Results in the generated DICOM instances consistent.
I think it is OK to leave the Equipment info as is. The the existing implementation already tries to parse out the App SDK version, so the software that generates the DICOM instance is correct. More important is the AI model info encapsulated in the contributing equipment, which is added by this PR.
Signed-off-by: bluna301 <luna.bryanr@gmail.com>
Thanks Ming. I agree with leaving Maybe we should consider making |
Signed-off-by: bluna301 <luna.bryanr@gmail.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
Signed-off-by: bluna301 <luna.bryanr@gmail.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
Signed-off-by: bluna301 <luna.bryanr@gmail.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
Signed-off-by: bluna301 <luna.bryanr@gmail.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
Signed-off-by: bluna301 <luna.bryanr@gmail.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
Signed-off-by: bluna301 <luna.bryanr@gmail.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
Signed-off-by: bluna301 <luna.bryanr@gmail.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
From Contributing Equipment Sequence for DICOM SEG Writer discussion.
DICOMSegmentationWriterOperator
updates to align with the other DICOM writer operators and the IHE Radiology AI Results criteria.This initial commit adds
model_info
as an optional parameter to theDICOMSegmentationWriterOperator
, allowing for theContributingEquipmentSequence
nesting in the DICOM SEG output:@MMelQin, a few thoughts for you after this initial commit:
segment_descriptions
andmodel_info
arguments are equivalent? As currently implemented, users can input different values for each fieldmodel_info
as a required or optional argument? I believe this is required for other DICOM writersequipment_info
argument to Seg Writer as 3/4 of the tag values are currently hard coded into the operator (see below). If you think these tags should always contain the MONAI Deploy App SDK information, we can leave this how it is; if you think these tags should be dynamic based on user input, I can addequipment_info
as an optional argument to the Seg Writer and pass these values accordingly