DICOM Seg Writer Op Tag Writing Updates #533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Contributing Equipment Sequence for DICOM SEG Writer discussion.
DICOMSegmentationWriterOperator
updates to align with the other DICOM writer operators and the IHE Radiology AI Results criteria.This initial commit adds
model_info
as an optional parameter to theDICOMSegmentationWriterOperator
, allowing for theContributingEquipmentSequence
nesting in the DICOM SEG output:@MMelQin, a few thoughts for you after this initial commit:
segment_descriptions
andmodel_info
arguments are equivalent? As currently implemented, users can input different values for each fieldmodel_info
as a required or optional argument? I believe this is required for other DICOM writersequipment_info
argument to Seg Writer as 3/4 of the tag values are currently hard coded into the operator (see below). If you think these tags should always contain the MONAI Deploy App SDK information, we can leave this how it is; if you think these tags should be dynamic based on user input, I can addequipment_info
as an optional argument to the Seg Writer and pass these values accordingly