Skip to content

lowered logging level thats flooding logs #54

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

neildsouth
Copy link
Collaborator

Description

Fixes # .

A few sentences describing the changes proposed in this pull request.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth neildsouth requested a review from mocsharp November 7, 2023 16:49
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #54 (1fe86ed) into develop (758ccea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop         #54   +/-   ##
=============================================
  Coverage   97.47191%   97.47191%           
=============================================
  Files             12          12           
  Lines            356         356           
  Branches          37          37           
=============================================
  Hits             347         347           
  Misses             7           7           
  Partials           2           2           
Flag Coverage Δ
unittests 97.47191% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 758ccea...1fe86ed. Read the comment docs.

Signed-off-by: Neil South <neil.south@answerdigital.com>
@mocsharp
Copy link
Contributor

mocsharp commented Jan 5, 2024

@dependabot recreate

@@ -20,7 +20,7 @@ namespace Monai.Deploy.WorkflowManager.Logging
{
public static partial class Log
{
[LoggerMessage(EventId = 500000, Level = LogLevel.Information, Message = "Bypass authentication.")]
[LoggerMessage(EventId = 500000, Level = LogLevel.None, Message = "Bypass authentication.")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to set this to debug instead of none?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants