Skip to content

fix: unexpected keyword argument reorder #120

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

superpung
Copy link

In the definition of the VerilogGraphGenerator class, one of the arguments of its generate method is do_reorder:

def generate(self, signalname, identical=False, walk=True, step=1, do_reorder=False, delay=False):

However, in the example_graphgen.py file, this argument is mistakenly referred to as reorder.
graphgen.generate(target, walk=options.walk, identical=options.identical,
step=options.step, reorder=options.reorder, delay=options.delay)

So when running python3 pyverilog/examples/example_graphgen.py -t top -s top.led test.v, I encountered error messages that are as follows:

Generating LALR tables
WARNING: 183 shift/reduce conflicts
Traceback (most recent call last):
  File "/path/to/pyverilog-demo/pyverilog/examples/example_graphgen.py", line 107, in <module>
    main()
  File "/path/to/pyverilog-demo/pyverilog/examples/example_graphgen.py", line 100, in main
    graphgen.generate(target, walk=options.walk, identical=options.identical,
TypeError: VerilogGraphGenerator.generate() got an unexpected keyword argument 'reorder'

@8ware
Copy link

8ware commented Aug 13, 2024

Fixes #97 and #117.

@8ware
Copy link

8ware commented Aug 13, 2024

Bug has been introduced in commit 7086786.

@superpung
Copy link
Author

/cc @shtaxxx

@barnard33-233
Copy link

@shtaxxx

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants