feat: message forwarding #2598
Open
feat: message forwarding #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
more or less done, just need to add mention/role mention handling and partialmessage support... but still 403ing on my bot 😔 |
|
unlucky bcs its 95% out. you're in th holdout group. try making a new bot |
JustaSqu1d
added
priority: medium
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
DA-344
reviewed
Nov 27, 2024
|
@NeloBlivion status? |
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
auto-merge was automatically disabled
February 6, 2025 03:15
Head branch was pushed to by a user without write access
Lulalaby
previously approved these changes
Feb 6, 2025
|
ah yeah, forgot to tick that box; as far as i've tested there haven't been any issues. |
Dorukyum
requested changes
Feb 10, 2025
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Lulalaby
reviewed
Feb 28, 2025
|
As far as I've tested it operates fine, would appreciate others testing if they may know of any edge cases/weird behaviour with the attributes of |
|
(Actually haven't done a full review of docs so maybe that'd be a good idea) |
Paillat-dev
approved these changes
Mar 6, 2025
JustaSqu1d
suggested changes
Mar 7, 2025
Comment on lines
+1496
to
+1497
| A reference to the :class:`~discord.Message` you are replying to or forwarding, this can be created using | ||
| :meth:`~discord.Message.to_reference` or passed directly as a :class:`~discord.Message`. When replying, you can control |
There was a problem hiding this comment.
Suggested change
| A reference to the :class:`~discord.Message` you are replying to or forwarding, this can be created using | |
| :meth:`~discord.Message.to_reference` or passed directly as a :class:`~discord.Message`. When replying, you can control | |
| A reference to the :class:`~discord.Message` you are replying to or forwarding, this can be created using | |
| :meth:`~discord.Message.to_reference` or passed directly as a :class:`~discord.Message`. When replying, you can control |
Two things here
- this is a run-on sentence. Please reword and fix.
- "you" is too casual and the sentence should be reworded in passive voice.
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
Signed-off-by: Lala Sabathil <lala@pycord.dev>
|
This pr should be marked as fixing |
|
done but i still won't pay you |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements message forwarding, alongside some small cleanups for other message features.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.