Skip to content
This repository was archived by the owner on Mar 18, 2022. It is now read-only.

Int parse error #53

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rahulghangas
Copy link

@rahulghangas rahulghangas commented May 29, 2021

Return relevant error if parsing of integer argument for (incr, incr_by, decr, decr_by) fails

@evoxmusic evoxmusic self-requested a review May 30, 2021 17:58
@evoxmusic
Copy link
Contributor

Hey @rahulghangas - thank you for this PR. Can you take a look at the tests? It seems that one is failing. Thank you 🙏

@rahulghangas
Copy link
Author

rahulghangas commented May 31, 2021

Ah yep, that's the test that I added. I believe it might be related to a deeper bug since the error returned has characters missing, I will debug it when I get back to my machine later.

@rahulghangas
Copy link
Author

@evoxmusic please review again

@evoxmusic
Copy link
Contributor

Sure, I'll this weekend

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants