Bugfix: Issue #97 - Ignore add/change messages from Chokidar on files that don't match the pattern. #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files that don't match the pattern.
|
Update: I am submitting a PR to Chokidar for the underlying issue. If that gets merged then this PR can be replaced with a dependency update instead. That'd be better. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
Chokidar has a bug where it does not filter paths by the provided pattern if they are inside a symlink. The bug is two years old.
This PR rechecks the file path against the pattern if we're watching to work around the Chokidar bug.
It adds a dependency on minimatch but that dependency already existed via a transient dependency (actually several versions are referenced currently due to already existing incorrect transient dependencies on glob in some reporters).
Chokidar issue:
paulmillr/chokidar#967
When that's fixed this PR can be reverted, but the issue is 2 years old already (reported 2020).