Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs(cookbook): update class handling #7411

Merged
merged 3 commits into from
Apr 2, 2025
Merged

docs(cookbook): update class handling #7411

merged 3 commits into from
Apr 2, 2025

Conversation

alimrb
Copy link
Contributor

@alimrb alimrb commented Mar 11, 2025

current code results in unexpected behavior when props.class was an array. Updated to:

class={[props.class, isActive && activeClass ? activeClass : ""]}

ensuring proper class concatenation and maintaining Tailwind's expected behavior.

This fixes styling inconsistencies and improves component reliability.

resulted in unexpected behavior when `props.class` was an array.
Updated to:

`class={[props.class, isActive && activeClass ? activeClass : ""]}`

ensuring proper class concatenation and maintaining Tailwind's expected behavior.

This fixes styling inconsistencies and improves component reliability.
@alimrb alimrb requested a review from a team as a code owner March 11, 2025 12:36
Copy link

changeset-bot bot commented Mar 11, 2025

⚠️ No Changeset found

Latest commit: f8b8cc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alimrb alimrb requested a review from a team as a code owner March 11, 2025 12:38
@maiieul maiieul changed the title Update index.mdx docs(cookbook): update class handling Mar 11, 2025
Copy link
Contributor

github-actions bot commented Apr 2, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview f8b8cc9

@maiieul maiieul enabled auto-merge (squash) April 2, 2025 19:59
@maiieul maiieul dismissed their stale review April 2, 2025 20:00

it's my review 😅

@maiieul maiieul merged commit 7d9ed00 into QwikDev:main Apr 2, 2025
14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants