Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: set default value of lint to false to improve the execution per… #7425

Merged
merged 5 commits into from
Mar 25, 2025
Merged

fix: set default value of lint to false to improve the execution per… #7425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1aa02ec
fix: set dCefault value of lint to false to improve the execution per…
Mar 15, 2025
2988e58
Create selfish-shirts-cover.md
JerryWu1234 Mar 15, 2025
91a69fa
fix test
Mar 15, 2025
df076ec
fix default vlaue
Mar 17, 2025
cba3161
Merge branch 'main' into 6837_add_lint
wmertens Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/selfish-shirts-cover.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'base': patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed this (I fixed it already in a different commit)

but for next time, please verify that this has a real package name or else it breaks the release

thanks!

---

fix: set default value of lint to false to improve the execution performance
4 changes: 1 addition & 3 deletions packages/qwik/src/optimizer/src/plugins/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export function createQwikPlugin(optimizerOptions: OptimizerOptions = {}) {
clickToSource: ['Alt'],
},
inlineStylesUpToBytes: 20000,
lint: true,
lint: false,
experimental: undefined,
};

Expand Down Expand Up @@ -334,8 +334,6 @@ export function createQwikPlugin(optimizerOptions: OptimizerOptions = {}) {

if (typeof updatedOpts.lint === 'boolean') {
opts.lint = updatedOpts.lint;
} else {
opts.lint ??= updatedOpts.buildMode === 'development';
}

if ('experimental' in updatedOpts) {
Expand Down