Skip to content

Conversation

GuEe-GUI
Copy link
Contributor

@GuEe-GUI GuEe-GUI commented Jun 30, 2025

拉取/合并请求描述:(PR description)

[

  1. Configure the kernel default vaddr by RAM and TEXT offset.
  2. Check the p_addr 2M align when set the stride in rt_hw_mmu_map.

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

1. Configure the kernel default vaddr by RAM and TEXT offset.
2. Check the p_addr 2M align when set the stride in `rt_hw_mmu_map`.

Signed-off-by: GuEe-GUI <2991707448@qq.com>
@github-actions github-actions bot added Arch: ARM/AArch64 BSP related with arm libcpu labels Jun 30, 2025
@GuEe-GUI
Copy link
Contributor Author

@Rbb666

@@ -54,7 +54,7 @@

/* restrict virtual address on usage of RT_NULL */
#ifndef KERNEL_VADDR_START
#define KERNEL_VADDR_START 0x1000
#define KERNEL_VADDR_START (ARCH_RAM_OFFSET + ARCH_TEXT_OFFSET)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个似乎更多偏向于Kconfig中进行配置了。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARCH_RAM_OFFSET 和 ARCH_TEXT_OFFSET 就是 Kconfig 配置出来的

@GuEe-GUI GuEe-GUI requested a review from BernardXiong July 2, 2025 02:14
@Rbb666 Rbb666 merged commit a894796 into RT-Thread:master Jul 4, 2025
60 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Arch: ARM/AArch64 BSP related with arm libcpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants