New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support for PHP 8.4 #6

Open

CatoTH wants to merge 2 commits into S1SYPHOS:main from CatoTH:main

CatoTH commented Nov 23, 2024

Hi!
It would be great if your library would support PHP 8.4 (without deprecations). Here would be my suggestion:

Use \Random\Randomizer::getRandom() instead of lcg_value (if available)
Added nullability to parameters when appropriate
Removed some null values if I couldn't find a nullable use (expect for from within test cases)
Removed default parameters before mandatory parameters
One unused import (unreleated)

CatoTH added 2 commits

November 23, 2024 09:26


          Support for PHP 8.4

5eeb6e6


          Ignore psalm errors

26d63ec

CatoTH mentioned this pull request

PHP 8.4 Compatibility CatoTH/antragsgruen#980

Closed

Owner

S1SYPHOS commented Nov 23, 2024

I'll look into it, thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet