feat: allow simplifying DAEs to index zero, better DAE initialization #3240
+92
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baggepinnen
reviewed
Nov 27, 2024
|
|
||
| Perform the Pantelides algorithm to transform a higher index DAE to an index 1 | ||
| DAE. `kwargs` are forwarded to [`pantelides!`](@ref). End users are encouraged to call [`structural_simplify`](@ref) | ||
| instead, which calls this function internally. | ||
| instead, which calls this function internally. If `to_index_zero` is true, the DAE will be reduced to an index 1 DAE. |
There was a problem hiding this comment.
Suggested change
| instead, which calls this function internally. If `to_index_zero` is true, the DAE will be reduced to an index 1 DAE. | |
| instead, which calls this function internally. If `to_index_zero` is true, the DAE will be reduced to an index 0 DAE. |
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.