[v9] fix: fix major compile time regression due to concrete_getu
#3692
+30
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Note that the getter ONLY works for problem-like objects, since it generates an observed | ||
| function. It does NOT work for solutions. | ||
| """ | ||
| Base.@nospecializeinfer function concrete_getu(indp, syms::AbstractVector) |
There was a problem hiding this comment.
Given the docstring, this could be typed to avoid mistakenly calling it with other types.
There was a problem hiding this comment.
The returned callable has this restriction. I'll have to think about how to handle that case, since it should just work on anything that isn't a solution or a lone parameter object/state vector.
AayushSabharwal
changed the title
concrete_getuconcrete_getu
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.