support Zygote@0.7 #566
Merged
support Zygote@0.7 #566
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to support ForwardDiff@1.0. Testing separately to see how CI looks.
|
unfortunately it looks like there are real inference failures caused by making everything a thunk in Zygote@0.7. |
|
These are real failures from this? I don't see how it would be related. Run master tests? |
|
From talking to Avik, Zygote@0.7 creates more thunks than 0.6 which can regress type stability. |
|
But that should only effect tests of reverse mode, since the standard only uses forward mode? |
The test that is failing is SimpleNonlinearSolve with |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support ForwardDiff@1.0. Testing separately to see how CI looks.