Add Muller's method #139
Add Muller's method #139
Conversation
|
Does this method only work for scalars? |
|
Yes. It only works for univariate, scalar functions. |
|
|
||
| function SciMLBase.solve(prob::NonlinearProblem, alg::SimpleMuller, args...; | ||
| abstol = nothing, maxiters = 1000, kwargs...) | ||
| @assert !isinplace(prob) "`SimpleMuller` only supports OOP problems." |
There was a problem hiding this comment.
Let's add some checks here for x is a 3 tuple and the elements are scalars
src/nlsolve/muller.jl
Outdated
| """ | ||
| SimpleMuller() | ||
|
|
||
| Muller's method. |
There was a problem hiding this comment.
Make the documentation a bit more detailed. References, restrictions like only scalars and such
|
@ChrisRackauckas how should we go about this? This is a significant deviation from how the other problems need to be framed |
|
Treating it as an IntervalNonlinearProblem solver and then getting the third guess as the midpoint would be fine. |
|
That sounds like a good way to proceed |
|
Just resurrecting this pull request. I can look into treating this as an |
|
this repo is no longer used. The PR would need to move to the NonlinearSolve.jl repo where SimpleNonlienarSolve.jl and BracketingNonlinearSolve.jl are sublibraries. |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This implements the method discussed in SciML/NonlinearSolve.jl#403.