Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[WIP] Simple JFNK #83

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] Simple JFNK #83

wants to merge 2 commits into from

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Oct 12, 2023

I was playing around with JNFK for DEQs and the Nonlinear Solve implementation is a bit too complicated for those purposes

  • Working Version
    • Batched Version
  • Testing
  • Are we okay with LinearSolve.jl as a dependency? -- Not really, let's use Krylov.jl directly as an extension
  • Preconditioners

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #83 (9858095) into main (1600f7c) will decrease coverage by 92.76%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #83       +/-   ##
==========================================
- Coverage   92.94%   0.19%   -92.76%     
==========================================
  Files          21      21               
  Lines        1049    1046        -3     
==========================================
- Hits          975       2      -973     
- Misses         74    1044      +970     
Files Coverage Δ
src/raphson.jl 0.00% <ø> (-90.00%) ⬇️
ext/SimpleNonlinearSolveNNlibExt.jl 0.00% <0.00%> (-90.25%) ⬇️
src/SimpleNonlinearSolve.jl 40.00% <0.00%> (-60.00%) ⬇️
src/broyden.jl 0.00% <0.00%> (-92.11%) ⬇️
src/jnfk.jl 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant