-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Python page mostly ok #33
Conversation
PR fails probably because The python envronment existing does not have scipy / numpy installed :/. Anyone have a solution to this ? Should we just add Python package to the CI ? |
I guess so, that must be how all Python people do their CIs, no? 🤷 |
Nice addition! For Python CI we could use the actions to setup Python, here there are many recipes: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python The simplest is probably the one with specific Python version and install of requirements:
Python requirements should be provided with the usual requirements.txt |
Deploy scipy / numpy in docs too
It seems |
Nice! I guess @pietroppeter 's suggestion would be the way to go in the future, but just to get it working the pip install works fine |
Someone needs to approve in order to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some small changes.
Aside from that thanks a lot! 🥳
Co-authored-by: Vindaar <basti90@gmail.com>
Co-authored-by: Vindaar <basti90@gmail.com>
Co-authored-by: Vindaar <basti90@gmail.com>
Co-authored-by: Vindaar <basti90@gmail.com>
Co-authored-by: Vindaar <basti90@gmail.com>
Co-authored-by: Vindaar <basti90@gmail.com>
Co-authored-by: Vindaar <basti90@gmail.com>
Co-authored-by: Vindaar <basti90@gmail.com>
Fine by me now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just a typo and a note to add some text in the julia file if you are not going to add it yet 😀
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
No description provided.