Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

work started on julia page #34

Merged
merged 28 commits into from
Nov 15, 2021
Merged

work started on julia page #34

merged 28 commits into from
Nov 15, 2021

Conversation

Clonkk
Copy link
Member

@Clonkk Clonkk commented Oct 29, 2021

No description provided.

@Clonkk
Copy link
Member Author

Clonkk commented Nov 5, 2021

Will clean-up the file writing once pietroppeter/nimib#64 is done (nbFile is more elegant)

@Clonkk Clonkk mentioned this pull request Nov 5, 2021
Merged
@pietroppeter
Copy link
Contributor

I realized I forgot to bump version to 0.2.2 in nimble file before release. I see now this is probably the reason why this fails, so I will release a 0.2.3

@Clonkk Clonkk marked this pull request as ready for review November 10, 2021 13:51
@Clonkk
Copy link
Member Author

Clonkk commented Nov 11, 2021

This is mostly done, if someone could kindly review it that'd be great :)

@Vindaar
Copy link
Member

Vindaar commented Nov 11, 2021

Great, will read it later!

HugoGranstrom
HugoGranstrom requested changes Nov 11, 2021
View reviewed changes
Copy link
Member

@HugoGranstrom HugoGranstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :D I've learnt a lot about interfacing with Julia now.

I think it's mostly grammatical things I have noted with one questions somewhere in there 🤣

Clonkk and others added 12 commits November 11, 2021 17:12
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/basics.nim
8bc3e01 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/basics.nim
989227a 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/basics.nim
c45e85e 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/basics.nim
f870d0b 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/basics.nim
fea59c1 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/nimjl_arrays.nim
a6c7ea4 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/nimjl_arrays.nim
c4ccc2e 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/nimjl_arrays.nim
6dd6776 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/nimjl_arrays.nim
c2d41c6 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/basics.nim
d133c9c 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/basics.nim
340f5bd 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/basics.nim
918d017 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
Clonkk and others added 5 commits November 11, 2021 20:56
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/nimjl_arrays.nim
f6fcfbd 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/nimjl_conversions.nim
b46c5d4 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/nimjl_conversions.nim
a7adc66 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk @HugoGranstrom
Update book/external_language_integration/julia/nimjl_conversions.nim
22039d3 
Co-authored-by: Hugo Granström <5092565+HugoGranstrom@users.noreply.github.com>
@Clonkk
removing file shouldn't be visible
09559b8
@Clonkk Clonkk merged commit 288bd7f into main Nov 15, 2021
@Clonkk Clonkk deleted the clonk_julia_page branch November 15, 2021 09:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@HugoGranstrom HugoGranstrom HugoGranstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Clonkk @pietroppeter @Vindaar @HugoGranstrom