Improve error logging while in SSI

[jdarwood007]

When a error occurs on a remote script, the full url is not logged. For example. Given a forum at: https://example.com/forum/ and site content at https://example.com/about/

Some examples here:
A error at /about/ will log just the /about/ if no query string is provided. A error at /about/?foo=bar will log just ?foo=bar
A error at https://sub.example.com/ will log no url

SMF will then when displaying the error log, give false urls due to its handling of urls in the viewer.

This will for SSI, attempt to use the correct URLs, falling back to various methods and default responses.

This is draft for now, I am performing testing with this.

[live627]

Suggested change

	'html' => $smcFunc['htmlspecialchars'](strpos($row['url'], 'cron.php') === false && !strpos($row['url'], 'https://') && !strpos($row['url'], 'http://') ? (substr($row['url'], 0, 1) == '?' ? $scripturl : '') . $row['url'] : $row['url']),
	'html' => $smcFunc['htmlspecialchars'](strpos($row['url'], 'cron.php') === false && !strpos($row['url'], 'https://') && !strpos($row['url'], 'http://') ? ($row['url'][0] === '?' ? $scripturl : '') . $row['url'] : $row['url']),

perf: Check string inline; do not check copy

[live627]

How's that for premature optimization, lol

[jdarwood007]

Looks good. I didn't even think about it using more memory that way as its copying it. Really wish PHP had kept {} as the way to navigate strings by character offset. So confusing think its an array. Yes I know technically in C/C++ a string is an array of chars, but still...

[jdarwood007]

I sent up a change for the strpos stuff I did. http:// could exist somewhere in the string and break this. So I check it starts with 0 and then flip the check.

<?php
$url = 'https://google.com';

var_dump(strpos($url, 'cron.php') === false);
var_dump(!strpos($url, 'https://'));
var_dump(!strpos($url, 'http://'));

$url = 'bad-actor/https://google.com';

var_dump(strpos($url, 'cron.php') === false);
var_dump(!(strpos($url, 'https://') === 0));
var_dump(!(strpos($url, 'http://') === 0));