Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[3.0]: Add support of placeholder attribute #8519

Merged

Conversation

dragomano
Copy link
Contributor

A small addition for the settings.

Does it make sense to create a similar PR for the 2.1 branch?

Signed-off-by: Bugo <cheetah@bk.ru>
@Oldiesmann
Copy link
Contributor

I don't think it makes sense to add this to 2.1 really. At this point most mods compatible with 2.1 final or newer will work fine with any version of 2.1. If we added this to 2.1, mod authors wouldn't be able to take advantage of it as easily since they'd either have to release a new version that's only "compatible" with versions that have this feature or they'd have to do version checking somewhere in the code to only output a placeholder if that version of SMF supports it. Many probably wouldn't see it as being worth the trouble.

It's fine in 3.0 since it's early in the development stages and mod authors aren't concerned with 3.0 at this point.

@dragomano
Copy link
Contributor Author

As far as I'm concerned, if a feature isn't supported in Admin.template.php, it's just ignored, so it's not a big deal. Right now, when I need to add a placeholder for a field, I have to use some hacky code like 'size' => '100" placeholder="Some text', even though the size isn't always necessary.

@DiegoAndresCortes
Copy link
Member

If we added this to 2.1, mod authors wouldn't be able to take advantage of it as easily since they'd either have to release a new version that's only "compatible" with versions that have this feature or they'd have to do version checking somewhere in the code to only output a placeholder if that version of SMF supports it. Many probably wouldn't see it as being worth the trouble.

I'm under the impression that it's just an array key so it would be ignored if it doesn't exist?
Anyways, I don't think it's necessary for 2.1, we can probably leave on 3.0 only.

@Sesquipedalian Sesquipedalian added this to the 3.0 Alpha 4 milestone Mar 20, 2025
@Sesquipedalian
Copy link
Member

Added to the roadmap for Alpha 4, which is the one for theme changes.

@Sesquipedalian Sesquipedalian merged commit 6b606fb into SimpleMachines:release-3.0 Mar 25, 2025
6 checks passed
@dragomano dragomano deleted the add_placeholder_option branch March 25, 2025 02:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants