Required changes in the driver for Door/Window Contact II [M] device #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 523a4d3 |
|
|
|
Duplicate profile check: Passed - no duplicate profiles detected. |
greens
reviewed
Apr 9, 2025
| @@ -0,0 +1,160 @@ | |||
| -- Copyright 2022 SmartThings | |||
greens
reviewed
Apr 9, 2025
There was a problem hiding this comment.
in general, folder names are lowercase and hyphenated, e.g.: bosch-button-contact
|
@JanJakubiszyn I would add the fingerprints back and I will close my PR (#2049) in favor of this one. |
hcarter-775
reviewed
Apr 9, 2025
| @@ -52,6 +52,8 @@ local TEMP_BOUND_RECEIVED = "__temp_bound_received" | |||
| local TEMP_MIN = "__temp_min" | |||
| local TEMP_MAX = "__temp_max" | |||
|
|
|||
| local HUE_MANUFACTURER_ID = 0x100B | |||
There was a problem hiding this comment.
please remove this Hue specific handling- it has recently been taken out of the drivers.
|
|
||
| local function is_bosch_open_close_button(opts, driver, device) | ||
| if device.network_type == device_lib.NETWORK_TYPE_MATTER and | ||
| device.manufacturer_info.vendor_id == BOSCH_VENDOR_ID then |
There was a problem hiding this comment.
Should the product id also be checked here?
12 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WWSTCERT-5977 driver adjustments
Check all that apply
Type of Change
Checklist
Description of Change
Creating a sub-driver which handles button functionality for Bosch Door/Window Contact II [M] device.
Summary of Completed Tests
Manual tests of button capability.