Skip to content

Support additional Room AC configurations #2056

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nickolas-deboom
Copy link
Contributor

Add additional profiles and handling for Room AC with support for heating-only or cooling-only.

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Add additional profiles and handling for Room AC with support for
heating-only or cooling-only.
Copy link

github-actions bot commented Apr 8, 2025

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Apr 8, 2025

Copy link

github-actions bot commented Apr 8, 2025

Test Results

   66 files  ±0    420 suites  ±0   0s ⏱️ ±0s
2 164 tests ±0  2 164 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 685 runs  ±0  3 685 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5e840d3. ± Comparison against base commit 7397af4.

Copy link

github-actions bot commented Apr 8, 2025

File Coverage
All files 84%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 86%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 48%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 5e840d3

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant