Skip to content

modular profile test #2078

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

modular profile test #2078

wants to merge 1 commit into from

Conversation

ctowns
Copy link
Contributor

@ctowns ctowns commented Apr 16, 2025

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@ctowns
Copy link
Contributor Author

ctowns commented Apr 16, 2025

Ignore all the deleted profiles, that was done so it was easier for me to pick out the DIP for the modular profile when it is spit out in the smartthings edge:drivers <driver id> cli command

The changes in the matter-sensor are representative of what I think we will need to do to get this working. It also includes the override to the supports_capability function that will be needed for our existing subscription logic in lua libs to work with modular profiles.

However, I was running into this issue while trying to onboard a matter-sensor device (specifically, the VDA AQS):

2025-04-16T04:19:31.718162924Z FATAL Matter Sensor  syntax error: [string "st/matter/generated/zap_clusters/CarbonMonoxi..."]:1: unexpected symbol near '+'
stack traceback:
	[C]: in local 'searcher'
	[string "env builder"]:92: in global 'require'
	[string "st/matter/generated/zap_clusters/CarbonMonoxi..."]:31: in main chunk
	[C]: in function 'pcall'
	[string "third_party.coxpcall.coxpcall"]:50: in field 'pcall'
	[string "env builder"]:94: in global 'require'
	[string "st/matter/generated/zap_clusters/CarbonMonoxi..."]:22: in metamethod '__index'
	[string "st/matter/generated/zap_clusters/CarbonMonoxi..."]:146: in metamethod '__index'
	[string "init.lua"]:481: in main chunk

The driver continuously crashes on this. I tried removing my lua libs changes and the issue persists. I walked back a few commits and the issue still persisted. As a sanity check I loaded the 55 lua libs and I did not see the issue anymore. @nickolas-deboom @hcarter-775 let's discuss this more in the morning, because even if it is not an issue related to this, we should still try to get to the bottom of what that issue is... or maybe I'm doing something wrong when building the lua libs? 🙃

@ctowns ctowns force-pushed the modular-profiles-test branch from 8dd287b to 4a58f4e Compare April 17, 2025 22:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant