Matter Thermostat: add support for modular profiles #2084
+468
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 10b1fce |
varzac
reviewed
Apr 18, 2025
|
|
||
| local function match_profile(driver, device) | ||
| -- must use profile switching on older hubs | ||
| if version.api < 14 and version.rpc < 7 then |
There was a problem hiding this comment.
I think this should be an or, if either one is too low we use a static profile
There was a problem hiding this comment.
Good catch - I updated this to an or instead, and I also left a note to update the RPC version to 8 once that gets into a build since I bumped the version number for the sake of tracking modular profile support 👍
|
Duplicate profile check: Passed - no duplicate profiles detected. |
| components: | ||
| - id: main | ||
| capabilities: | ||
| - id: airPurifierFanMode |
There was a problem hiding this comment.
Is the order of the capabilities going to match the order in existing profiles?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests