generic_zigbee_sensor_improvement #2093
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
Test Results 67 files 430 suites 0s ⏱️ Results for commit b81729b. ♻️ This comment has been updated with latest results. |
|
tuya_coverage.xml
zigbee-sensor_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against b81729b |
pInksenberg
force-pushed
the
generic_zigbee_sensor_improvement
branch
from
0f03911 to
21f22c9
Compare
pInksenberg
force-pushed
the
generic_zigbee_sensor_improvement
branch
4 times, most recently
from
7af243e to
9267b81
Compare
pInksenberg
force-pushed
the
generic_zigbee_sensor_improvement
branch
from
9267b81 to
b81729b
Compare
greens
reviewed
Apr 24, 2025
Comment on lines
+22
to
+23
| - 0xfe00 # EZVIZ private cluster | ||
| - 0xfe05 # EZVIZ private cluster |
There was a problem hiding this comment.
we usually capitalize the letters in our hex
greens
reviewed
Apr 24, 2025
Comment on lines
+66
to
+72
| local generate_event_from_emergency = function(driver, device) | ||
| device:emit_event(capabilities.button.button.pushed({ state_change = true })) | ||
| end | ||
|
|
||
| local ias_ace_emergency_handler = function(driver, device) | ||
| generate_event_from_emergency(driver, device) | ||
| end |
There was a problem hiding this comment.
these functions can be consolidated
greens
reviewed
Apr 24, 2025
Comment on lines
+26
to
+47
| local generate_event_from_zone_status = function(driver, device, zone_status, zb_rx) | ||
| local event | ||
| if zone_status:is_alarm1_set() or zone_status:is_alarm2_set() then | ||
| event = capabilities.contactSensor.contact.open() | ||
| else | ||
| event = capabilities.contactSensor.contact.closed() | ||
| end | ||
| if event ~= nil then | ||
| device:emit_event_for_endpoint( | ||
| zb_rx.address_header.src_endpoint.value, | ||
| event) | ||
| end | ||
| end | ||
|
|
||
|
|
||
| local ias_zone_status_attr_handler = function(driver, device, zone_status, zb_rx) | ||
| generate_event_from_zone_status(driver, device, zone_status, zb_rx) | ||
| end | ||
|
|
||
| local ias_zone_status_change_handler = function(driver, device, zb_rx) | ||
| generate_event_from_zone_status(driver, device, zb_rx.body.zcl_body.zone_status, zb_rx) | ||
| end |
There was a problem hiding this comment.
are we overwriting the defaults somewhere that makes it necessary to redefine them here?
greens
reviewed
Apr 24, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Refactoring zigbee-sensor driver, and adding support for tuya zigbee devices.
Summary of Completed Tests