-
Notifications
You must be signed in to change notification settings - Fork 111
Translations for the menu #360
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open
EmilsM
wants to merge
6
commits into
SnowdogApps:develop
Choose a base branch
from
magebitcom:feature/translations
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7615d7a
Translations - inital commit
EmilsM 44e5e36
Export translations
EmilsM 6c44b2d
Import Translations
EmilsM fa3a968
Import Translations
EmilsM bab0f4d
Adding translations for import categories
EmilsM 43e9f75
Works on all menus
EmilsM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <?php | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Snowdog\Menu\Api\Data; | ||
|
|
||
| interface NodeTranslationInterface | ||
| { | ||
| public const NODE_ID = 'node_id'; | ||
| public const STORE_ID = 'store_id'; | ||
| public const TITLE = 'title'; | ||
|
|
||
| /** | ||
| * @return int | ||
| */ | ||
| public function getNodeId(): int; | ||
|
|
||
| /** | ||
| * @param int $nodeId | ||
| * @return NodeTranslationInterface | ||
| */ | ||
| public function setNodeId(int $nodeId): NodeTranslationInterface; | ||
|
|
||
| /** | ||
| * @return int | ||
| */ | ||
| public function getStoreId(): int; | ||
|
|
||
| /** | ||
| * @param int $storeId | ||
| * @return NodeTranslationInterface | ||
| */ | ||
| public function setStoreId(int $storeId): NodeTranslationInterface; | ||
|
|
||
| /** | ||
| * @return string|null | ||
| */ | ||
| public function getTitle(): ?string; | ||
|
|
||
| /** | ||
| * @param string $title | ||
| * @return NodeTranslationInterface | ||
| */ | ||
| public function setTitle(string $title): NodeTranslationInterface; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| <?php | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Snowdog\Menu\Api; | ||
|
|
||
| use Magento\Framework\Api\SearchCriteriaInterface; | ||
| use Magento\Framework\Api\SearchResultsInterface; | ||
| use Magento\Framework\Exception\CouldNotDeleteException; | ||
| use Magento\Framework\Exception\CouldNotSaveException; | ||
| use Magento\Framework\Exception\NoSuchEntityException; | ||
| use Snowdog\Menu\Api\Data\NodeTranslationInterface; | ||
|
|
||
| interface NodeTranslationRepositoryInterface | ||
| { | ||
| /** | ||
| * Save node translation | ||
| * | ||
| * @param NodeTranslationInterface $translation | ||
| * @return NodeTranslationInterface | ||
| * @throws CouldNotSaveException | ||
| */ | ||
| public function save(NodeTranslationInterface $translation): NodeTranslationInterface; | ||
|
|
||
| /** | ||
| * Get node translation by ID | ||
| * | ||
| * @param int $translationId | ||
| * @return NodeTranslationInterface | ||
| * @throws NoSuchEntityException | ||
| */ | ||
| public function getById(int $translationId): NodeTranslationInterface; | ||
|
|
||
| /** | ||
| * Get node translation by node ID and store ID | ||
| * | ||
| * @param int $nodeId | ||
| * @param int $storeId | ||
| * @return NodeTranslationInterface | ||
| * @throws NoSuchEntityException | ||
| */ | ||
| public function getByNodeAndStore(int $nodeId, int $storeId): NodeTranslationInterface; | ||
|
|
||
| /** | ||
| * Get all translations for multiple nodes in a specific store | ||
| * | ||
| * @param array $nodeIds | ||
| * @param int $storeId | ||
| * @return NodeTranslationInterface[] | ||
| */ | ||
| public function getByNodeIds(array $nodeIds, int $storeId): array; | ||
|
|
||
| /** | ||
| * Get all translations for a node | ||
| * | ||
| * @param int $nodeId | ||
| * @return NodeTranslationInterface[] | ||
| */ | ||
| public function getByNodeId(int $nodeId): array; | ||
|
|
||
| /** | ||
| * Delete node translation | ||
| * | ||
| * @param NodeTranslationInterface $translation | ||
| * @return bool | ||
| * @throws CouldNotDeleteException | ||
| */ | ||
| public function delete(NodeTranslationInterface $translation): bool; | ||
|
|
||
| /** | ||
| * Delete node translation by ID | ||
| * | ||
| * @param int $translationId | ||
| * @return bool | ||
| * @throws CouldNotDeleteException | ||
| * @throws NoSuchEntityException | ||
| */ | ||
| public function deleteById(int $translationId): bool; | ||
|
|
||
| /** | ||
| * Delete all translations for a node | ||
| * | ||
| * @param int $nodeId | ||
| * @return bool | ||
| * @throws CouldNotDeleteException | ||
| */ | ||
| public function deleteByNodeId(int $nodeId): bool; | ||
|
|
||
| /** | ||
| * @param SearchCriteriaInterface $searchCriteria | ||
| * @return SearchResultsInterface | ||
| */ | ||
| public function getList(SearchCriteriaInterface $searchCriteria): SearchResultsInterface; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like duplicate piece of code. I think you can use the function getStoreViews().