-
Notifications
You must be signed in to change notification settings - Fork 555
Fix for issue 34, switched this.$el with evt.from #52
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
onDragUpdate was updated to use evt.from to call insertNodeAt, but onDragRemove was not updated accordingly.
@alnumac Could you specify which scenario this fix is correcting? |
@David-Desmaisons Moving an item from one list to another with animations enabled. |
Yes, i have the same problem, and looking for this. fix. Have to disable animation for current version. There is no such problem for previous vue2 version. |
@alnumac I will appreciate if you can do this fix. |
Please correct this bug and push a new release! Thank you So much! |
I also would be in favor of merging and releasing this as I just now ran into the same issue while upgrading a vue2 project to vue3 and moving items between lists of the same group throws the |
@David-Desmaisons what is missing for this to be merged? |
Please merge this PR and push a new release! |
solve drag between two group occur undefined problem, like offical pull request, SortableJS#52 Fix for issue 34, switched this.$el with evt.from SortableJS#52
onDragUpdate was updated to use evt.from to call insertNodeAt, but onDragRemove was not updated accordingly.
This pull request simply corrects this slight oversight, fixing a crash I was experiencing.