Skip to content

fix: Page Navigation State #933

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 4, 2025
Merged

fix: Page Navigation State #933

merged 9 commits into from
Jun 4, 2025

Conversation

Computerdores
Copy link
Collaborator

@Computerdores Computerdores commented May 15, 2025 •
edited
Loading

Summary

Fix #804.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience Priority: High An important issue requiring attention labels May 15, 2025
@CyanVoxel CyanVoxel moved this to 🚧 In progress in TagStudio Development May 15, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.3 milestone May 15, 2025
@Computerdores
Copy link
Collaborator Author

Everything should be working now.

Note: I had to change the constructing methods of BrowsingState to produce a string that is then later parsed. It would be good if those got extra scrutiny during the review to make sure I didn't miss any edge cases (I didn't find any during testing, but still)

@Computerdores Computerdores marked this pull request as ready for review May 15, 2025 21:22
@Computerdores Computerdores moved this from 🚧 In progress to 🏓 Ready for Review in TagStudio Development May 15, 2025
@Computerdores Computerdores added the Status: Review Needed A review of this is needed label May 15, 2025
@Computerdores Computerdores mentioned this pull request May 16, 2025
Merged
8 tasks
@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 👀 In review in TagStudio Development Jun 4, 2025
@CyanVoxel CyanVoxel linked an issue Jun 4, 2025 that may be closed by this pull request
[Bug]: Page Navigation State Incorrectly Refactored and Non-Functional #804
Closed
3 tasks
@CyanVoxel CyanVoxel moved this from 👀 In review to 🍃 Pending Merge in TagStudio Development Jun 4, 2025
CyanVoxel
CyanVoxel approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good in the code as far as I can tell, and the functionality seems to be restored to 9.4 behavior! Thank you so much for this major fix!!

@CyanVoxel CyanVoxel merged commit cf6c56c into TagStudioDev:Alpha-v9.5.3 Jun 4, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Jun 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@CyanVoxel CyanVoxel CyanVoxel approved these changes

Assignees
No one assigned
Labels
Priority: High An important issue requiring attention Status: Review Needed A review of this is needed Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience
Projects
TagStudio Development
Status: ✅ Done
Milestone
Alpha v9.5.3
Development

Successfully merging this pull request may close these issues.

[Bug]: Page Navigation State Incorrectly Refactored and Non-Functional
2 participants
@Computerdores @CyanVoxel