Skip to content

fix: Page Navigation State #933

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 9 commits into
base: Alpha-v9.5.3
Choose a base branch
from
Open

fix: Page Navigation State #933

wants to merge 9 commits into from

Conversation

Computerdores
Copy link
Collaborator

@Computerdores Computerdores commented May 15, 2025 •
edited
Loading

Summary

Fix #804.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience Priority: High An important issue requiring attention labels May 15, 2025
@CyanVoxel CyanVoxel moved this to 🚧 In progress in TagStudio Development May 15, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.3 milestone May 15, 2025
@Computerdores
Copy link
Collaborator Author

Everything should be working now.

Note: I had to change the constructing methods of BrowsingState to produce a string that is then later parsed. It would be good if those got extra scrutiny during the review to make sure I didn't miss any edge cases (I didn't find any during testing, but still)

@Computerdores Computerdores marked this pull request as ready for review May 15, 2025 21:22
@Computerdores Computerdores moved this from 🚧 In progress to 🏓 Ready for Review in TagStudio Development May 15, 2025
@Computerdores Computerdores added the Status: Review Needed A review of this is needed label May 15, 2025
@Computerdores Computerdores mentioned this pull request May 16, 2025
Draft
8 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: High An important issue requiring attention Status: Review Needed A review of this is needed Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience
Projects
TagStudio Development
Status: 🏓 Ready for Review
Milestone
Alpha v9.5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Computerdores @CyanVoxel