-
-
Notifications
You must be signed in to change notification settings - Fork 502
feat (form-core): Merging Form-level server errors with Field-level errors #1432
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open
theVedanta
wants to merge
7
commits into
TanStack:main
Choose a base branch
from
theVedanta:server-validation-merged-with-field-errors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat (form-core): Merging Form-level server errors with Field-level errors #1432
theVedanta
wants to merge
7
commits into
TanStack:main
from
theVedanta:server-validation-merged-with-field-errors
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit 9413ca6.
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1432 +/- ##
==========================================
- Coverage 89.24% 87.85% -1.40%
==========================================
Files 31 31
Lines 1432 1457 +25
Branches 366 376 +10
==========================================
+ Hits 1278 1280 +2
- Misses 137 155 +18
- Partials 17 22 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-validation-merged-with-field-errors
…-validation-merged-with-field-errors
…github.com/theVedanta/form into server-validation-merged-with-field-errors
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the previous
serverValidate
function just returning a string, we now return an object:This then maps to the field-level errors with the
setMeta
options.The only reason this is called a preliminary approach is because we are setting the
onServer
key of the errorMap differently.Previously, the error map for the form looked like so:
Now however, the onServer map is slightly different:
This causes some degree of inconsistency, which is why I would love some feedback on whether we can use some other property (or maybe create our own!) to manage the errors between fields and forms. This would not be a comprehensive property but just a map to sync them back and forth.
NextJS support has been pushed. Remix and Start coming soon.
Support for Array field types will also be done shortly.
Would love your feedback and comments on this approach before I proceed!
Solves the following issue: #1260