test(query-core): add test case for hydration #8949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 5839e07.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8949 +/- ##
===========================================
+ Coverage 44.09% 58.35% +14.25%
===========================================
Files 201 137 -64
Lines 8025 5312 -2713
Branches 1762 1392 -370
===========================================
- Hits 3539 3100 -439
+ Misses 4058 1921 -2137
+ Partials 428 291 -137 🚀 New features to boost your workflow:
|
TkDodo
reviewed
Apr 6, 2025
Comment on lines
+1172
to
+1177
| try { | ||
| await dehydrated.queries[0]?.promise | ||
| expect(true).toBe(false) | ||
| } catch (error) { | ||
| expect(error).toBe(testError) | ||
| } |
There was a problem hiding this comment.
I think this should be:
await expect(dehydrated.queries[0]?.promise).rejects.toBe(testError)
Comment on lines
+1187
to
+1188
| const originalNodeEnv = process.env.NODE_ENV | ||
| process.env.NODE_ENV = 'production' |
| process.env.NODE_ENV = originalNodeEnv | ||
| consoleMock.mockRestore() | ||
| await promise | ||
| queryClient.clear() |
There was a problem hiding this comment.
instead of clearing the queryClient at the end, let’s just not share a client between tests but have each test instantiate their own please.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve test coverage of
hydration.tsfrom 85% to 100%.Before
After