Remove prdicate typing for query filters

[Nick-Lucas]

No description provided.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 65a9840.

Command	Status	Duration	Result
nx affected --targets=test:sherif,test:knip,tes...	❌ Failed	2m 31s	View ↗
nx run-many --target=build --exclude=examples/*...	❌ Failed	6s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-04-05 09:44:14 UTC

[Nick-Lucas]

So @TkDodo I'm in two minds if we should go as far as stripping out the generics entirely. It's more of a breaking change to remove them than to leave them unused, especially since the 4th type param (query key) does get used currently.

What do you think?

[TkDodo]

TypeScript errors on unused type parameters:

src/utils.ts(19,3): error TS6133: 'TError' is declared but its value is never read.
src/utils.ts(20,3): error TS6133: 'TData' is declared but its value is never read.

so what option do we have other than deleting them?

[Nick-Lucas]

Should be possible to ignore the warnings I think? So it's more a question of where your mind is at as a maintainer

I didn't do anything today beyond start this draft, there will be tests failing as well that I can sort out either way

[TkDodo]

Should be possible to ignore the warnings I think?

this isn’t just an eslint warning - it’s a TS error that you would need to silence with ts-ignore, which is not something I’d recommend because if the comments get stripped, the error might resurface