#208 #207 Remove SimpleTest, Move logging to TcMenuLog library, Add m… #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should not merge this until TcMenuLog is released and more testing is performed. |
|
In fact the tests will not pass until TcMenuLog is pushed into the repository |
vzahradnik
reviewed
Sep 15, 2024
| @@ -11,7 +11,7 @@ namespace iotouch { | |||
| } | |||
| if (ticks++ > accel) { | |||
| ticks = 0; | |||
| accel = max(minTicks, uint8_t(accel / 2U)); | |||
| accel = internal_max(minTicks, uint8_t(accel / 2U)); | |||
There was a problem hiding this comment.
Maybe we should start using namespaces more. Something like tcmenu::max(...)
vzahradnik
approved these changes
Sep 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mbed SPI, SimpleTest removal, TcMenuLog library move.