-
Notifications
You must be signed in to change notification settings - Fork 29
Tilde update structure css #30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open
tildetilde
wants to merge
104
commits into
Technigo:main
Choose a base branch
from
oskarnordin:tilde-update-structure-css
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tilde update structure css #30
tildetilde
wants to merge
104
commits into
Technigo:main
from
oskarnordin:tilde-update-structure-css
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added high quality pictures
added file for quiz questions
Added CSS root
added data to quizdata.js
Tilde adding new images
Added link to about html file.
Added startQuiz button on top of the banner img.
git commit -mdded
Start quiz button function
Improved header and responsiveness
Improved footer design
Added logo and changed padding to adjust height
- Optimized images. - Made 2 + 2 cards.
Image optimization + cards fix
…eader when the user wants to get back to main
added scrollIntoView on backtomain-button, now it scrolls up to the h…
Tilde reset to working site
Tilde reduced motion
updated quiz styling
fixed button-css
changed size on h2 in result page
…ts-html updated about semantics and styling
update skip to main content for about
…ton-design update start quiz button
NiklasAbrahamsson
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Nice addition of accessibility-related facts — educational content like this helps raise awareness and build user understanding.
- Well done on the skip button and a clear tab order, both of which enhance keyboard navigation and screen reader usability.
- Focus trapping works as intended, and keyboard navigation is seamless across components.
- The feedback system — using both color and text — is a thoughtful and inclusive touch, ensuring all users receive the information they need.
- The color palette in dark mode is well chosen and visually pleasant.
- Overall structure and layout of elements are clear and well-organized.
- Color contrast ratios meet accessibility standards.
- Great use of both standard labels and ARIA labels, improving screen reader support.
- Inclusion of a reduced motion option is excellent — it supports users with motion sensitivity and respects system preferences.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.