-
Notifications
You must be signed in to change notification settings - Fork 29
AccessibilityProject - Linda L #44
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open
llindallarsson
wants to merge
12
commits into
Technigo:main
Choose a base branch
from
llindallarsson:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiklasAbrahamsson
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Great implementation of the skip button — it improves usability for keyboard and screen reader users.
- Nicely done highlighting the currently active page, which helps with orientation and navigation.
- The progress bar is well-executed and informative.
- Tab order is logical and intuitive, enhancing keyboard navigation.
- Excellent that initial focus is automatically set to the first radio button — this is an important detail for accessibility.
- Error handling is implemented effectively, providing helpful and clear feedback to users.
On the results page:
- Feedback is well-presented and accessible.
- The Restart Quiz function is nicely integrated and easy to find.
- Great consideration for screen reader users through the use of accessible icons.
Lastly, it’s good to see that the team has recognized the remaining issues flagged by the WAVE accessibility tool. Acknowledging these areas for improvement shows awareness and a commitment to refinement.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to deployed site: https://accessibility-project-lindal.netlify.app/