-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
split list keyboard into lists per row #134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change styles to avoid breaks per row
alodahl
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By gum, you've done it! 👏🏼
alodahl
added a commit
that referenced
this pull request
Oct 30, 2021
* docs(contributing): move readme directions to own file (#61) * docs: Resolve a typo with commands (#87) * docs: test commit Co-authored-by: tilaprimera <tilaprimera@users.noreply.github.com> * Resolves #65 - Finish ORM Setup (#91) * Fixes #65 - Finish ORM Setup - Ensure we can connect to the DB before launching Express - Use sqlite for normal dev mode; postgres for production - Upgrade sequelize and postgres npm packages since the versions we were using hung trying to connect to pg - Use the sequelize.sync functionality to automatically setup any table(s) * Allow either type of DB in development mode - in dev mode, have default DB_URL of sqlite - in prod, DB_URL must be specified * fix .gitignore to have correct sqlite db name * clean up package.json scripts * Fix port used in README and remove steps related to when the files were served by http-server (now using express) (#62) * orm.js updated with model for UserAnswers * updates to UserAnswers model * 34 caps lock toggle (#98) * fixed caps lock sync issue, capslock on is a keydown and capslock off is a keyup event * deleted unecesseray if condition in handle function for capslock * docs: add step for PR description * Replace repetitive if blocks with lookup * Remove unneeded files (#107) * Added post endpoint to save an user answer * refactor: Remove jQuery when possible (#109) * Replaced jQuery DOM Selectors with in-built one * return res object in handlers * added backend call when the answer is correct * solved merge conflict * fix: Add defer to script elements for better loading experience (#113) * fixed mistake with site url * added find by user_id validation * deleted autoincrement config on UserAnswers model * installing express-openid-connecyt * updating the README with instructions for Auth0 * integrating Auth0 middleware into server * Revert "refactor: Remove jQuery when possible (#109)" This reverts commit 9c9d786. * Add cross-env package for processing env variables in any platform (#112) Co-authored-by: Paul Diaz Navarrete <paul.diaz@bairesdev.com> * Replacing Jquery with Fetch in main.js(#114) * feat: add shortcut type tag to JSON object and main screen (#103) * Addressing code review comments * Replace jQuery.text function * fixed issues with in-built DOM selector * remove window height listener in favour of css container height value from 800px to 100vh remove unneeded window height listener container height is already set by the css value * feat: add toggle to show/hide button hint (#127) * Updated ecstatic to v 4.1.4 (#126) * get last 3 timing given the user and question id endpoint * - integrated history endpoint - param in query instead of body in endpoint request * refactored history.js * fix: split list keyboard per row (#134) change styles to avoid breaks per row * fix: Command hotkeys escaped instead of executed #45 (#118) * Refactor the jquery functions in main.js * Resolving problems * Add highlight for Fn key in case F1-F12 is pressed. Fixes #29 * fixed all the comments made in review stage * Fixes #29. Add Fn un-highlight on release F1-12 * Fixes #29. Change jQuery to native DOM functions. Move macVSCode shortcut to the end. * added mock userId on the server * Added favicon Used serve-icon middleware to serve favicon. * Fixes #138. Add clear prompt for all hint keys (#139) * Resolve problem with keys that are not used, remove a comment * App can use Auth0 or local dev auth (#133) * Fixes #74 - fake login/logout for local dev - refactor auth setup so it is the same for the rest of the code regardless if it's fake dev or Auth0 - use express-session with sequelize store to handle sessions (they will persist dev reload) - add dummy login state message to bottom of index page so dev can use login/logout before buttons are added * make .env.example a little more user-friendly * add .git.local ignore so it can be used to switch between Auth0 and local dev without accidentally checking it in * Fully integrate Auth0 and local dev - Auth create user upon login or root request - Protect all /user API routes to need a valid signed-in user or they will respond with 401 - fix ORM data models so they have default values and work correctly with postgres * fix comments * Add Auth0 callback instructions (#141) * Add indexes: user_answers_created_at_user_id_question_number, user_answers_created_at_user_id * Integrate all auth-dependent API stories into working app version (#142) * Fixes #74 - fake login/logout for local dev - refactor auth setup so it is the same for the rest of the code regardless if it's fake dev or Auth0 - use express-session with sequelize store to handle sessions (they will persist dev reload) - add dummy login state message to bottom of index page so dev can use login/logout before buttons are added * make .env.example a little more user-friendly * add .git.local ignore so it can be used to switch between Auth0 and local dev without accidentally checking it in * Fully integrate Auth0 and local dev - Auth create user upon login or root request - Protect all /user API routes to need a valid signed-in user or they will respond with 401 - fix ORM data models so they have default values and work correctly with postgres * fix comments * do not save or fetch data unless logged in * fix get history endpoint to lookup by logged in user id from request * Implements #77 - replaces all localStorage lookups with saved /user/progress API call - remove commented code - add const/let variable declarations when missing * Add API integration specs using jasmine + supertest * Bump ini from 1.3.5 to 1.3.8 (#145) Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Login button shows correct status centered (#146) * - Add login and logout buttons to the top of the main page * - Adjust account-info's margins * - 2nd draft of login button. Account info is centered in the whitespace above the read container Co-authored-by: Jackie Zhang <hausekey@github.com> * Bump jose from 2.0.2 to 2.0.5 (#148) Co-authored-by: Josseline Perdomo <joss.desi@gmail.com> Co-authored-by: Sraddhanjali Acharya <tilaprimera@gmail.com> Co-authored-by: tilaprimera <tilaprimera@users.noreply.github.com> Co-authored-by: Bill DePhillips <355438+vegetabill@users.noreply.github.com> Co-authored-by: Ambika Sadhu <34772783+ambikasadhu1101@users.noreply.github.com> Co-authored-by: ashley-g <69818337+ashley-g@users.noreply.github.com> Co-authored-by: Nadya Djojosantoso <hello@nadyafebi.com> Co-authored-by: Sergio Moreno Baeza <mobasergio@protonmail.com> Co-authored-by: Josseline Perdomo <josselineperdomoc@gmail.com> Co-authored-by: David Stroud <31050943+dapper-gh@users.noreply.github.com> Co-authored-by: Aryan Verma <aryanv2001@gmail.com> Co-authored-by: racheltl <64662730+racheltl@users.noreply.github.com> Co-authored-by: Izzy Berzsenyi <iberzsenyi@yahoo.com> Co-authored-by: Paúl Díaz Navarrete <paulrrdiaz@gmail.com> Co-authored-by: Paul Diaz Navarrete <paul.diaz@bairesdev.com> Co-authored-by: Astha Upadhyay <01astha@gmail.com> Co-authored-by: Beleicia Bullock <10715618+belebull@users.noreply.github.com> Co-authored-by: Linh <lhvo2112@gmail.com> Co-authored-by: frankyfrankfrank <adam@webadamfrank.com> Co-authored-by: Dimitrij Agal <dimitrij@traveloka.com> Co-authored-by: Anurag sati <52669445+anuragsati@users.noreply.github.com> Co-authored-by: Mayra Lucia Navarro <luciagirasoles@gmail.com> Co-authored-by: Kat Shambaugh <44981851+KatShambaugh@users.noreply.github.com> Co-authored-by: Ybrahin Martinez <ybrahimmartinez09@gmail.com> Co-authored-by: Oleksandra <karska.dev@gmail.com> Co-authored-by: Nidhish <55269918+nidhishs@users.noreply.github.com> Co-authored-by: Oleksandra <4979096+Karska-dev@users.noreply.github.com> Co-authored-by: Jackie Zhang <hausekey@github.com> Co-authored-by: Jackie Zhang <zhang.jackiee@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change styles to avoid breaks per row
close #57