-
Notifications
You must be signed in to change notification settings - Fork 16
Include port in console run hint #9
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Just a request for a docstring. We like everything to have docstrings, even if it occasionally seems redundant...
@@ -45,6 +46,12 @@ def __rich_console__( | |||
yield from line | |||
yield new_line | |||
|
|||
def _run_command(self) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstring please!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! I also added a docstring to the DevConsoleHeader class to match the other renderables in the file
I've stumbled over the same problem. Currently I'm using the pull request sources to use the --dev mode but would like to switch back to the regular version as I face problems with 'textual keys'. |
This PR displays the port, but it doesn't implement the |
This was misleading... I wanted to refer to the
|
You have old code. Please update Textual abs textual-dev |
Well, sorry, my fault. |
No worries! |
This PR adds the
--port
argument to the run hint provided by the Textual dev console.Unfortunately, something I'm working on also uses port 8081, so whenever I'm using the Textual console I'm always using a different port. This is a pretty minor addition but it'd make things ever-so-slightly easier for me!