-
Notifications
You must be signed in to change notification settings - Fork 20.1k
Adding Triangular Prism #6453
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Adding Triangular Prism #6453
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6453 +/- ##
============================================
+ Coverage 75.04% 75.05% +0.01%
- Complexity 5534 5535 +1
============================================
Files 685 685
Lines 19208 19209 +1
Branches 3706 3706
============================================
+ Hits 14414 14417 +3
Misses 4239 4239
+ Partials 555 553 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@DEVANSH-GAJJAR please fix the failing workflows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made some changes , I hope i am on the right path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the failing build and clang format worklfow @DEVANSH-GAJJAR
@@ -102,4 +102,19 @@ public static double volumePyramid(double baseArea, double height) { | |||
public static double volumeFrustumOfCone(double r1, double r2, double height) { | |||
return (Math.PI * height / 3) * (r1 * r1 + r2 * r2 + r1 * r2); | |||
} | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is not indented correctly (compare with other methods)
clang-format -i --style=file path/to/your/file.java