Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Initial version of cell death #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Initial version of cell death #6

wants to merge 1 commit into from

Conversation

boaguilar
Copy link
Contributor

No description provided.

@@ -1,6 +1,6 @@
# ABM microcarriers

This software is used for the Proof of Concept project by the [CMMC](thecmmc.org). The technical report describing the proof of concept can be found [here](https://zenodo.org/record/4264611).
This software is used for the Proof of Concept project by the [CMMC](thecmmc.org).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you did not base this branch on the most up to date master branch. For future branches it's best to do a git pull on the master branch just before you create a new branch. For now we can just put this addition in:

Suggested change
This software is used for the Proof of Concept project by the [CMMC](thecmmc.org).
This software is used for the Proof of Concept project by the [CMMC](thecmmc.org). The technical report describing the proof of concept can be found [here](https://zenodo.org/record/4264611).

@JaroCamphuijsen
Copy link
Member

Also when trying to run this model, (as well as the one in the master branch) it fails on a check in line 237 of model_routine_config.cpp:

CHECK( NUM_PARTICLE_EXTRA_OUTPUT_REALS == 1	 );

This should be set to 7 as we have 7 output reals.

Copy link
Member

@JaroCamphuijsen JaroCamphuijsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boaguilar Can you change the two things I mentioned? Then we can merge this! Yippee!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants