fix(vscode): support aliased references #4309
Conversation
| unaliased = table.copy() | ||
| if unaliased.args.get("alias") is not None: | ||
| unaliased.set("alias", None) |
There was a problem hiding this comment.
There's all sorts of modifiers that can be attach to an exp.Table, such as joins, tablesamples etc. You'd need to drop all of them except catalog, db and this or leverage existing helpers such as sqlmesh.core.dialect.find_tables which should do that for you.
However, looking into the whole function again, I don't think you need to find (or clean up) the references on your own, isn't that provided by model.depends_on?
There was a problem hiding this comment.
I guess the problem is that if there's an alias the depends_on check won't work correctly, though we still want to get a match. In all other cases you're right. find_tables could be a good suggestion.
There was a problem hiding this comment.
I've also realised ... it was failing with an exception and if say there are more examples where this can happen, I think it's better we wrap it in a try catch.
No description provided.