Fix: video parsing and Markdown export issues #1955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hector-Zhuang is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses two issues related to
<video>elements in the editor:Video parsed as an image
Previously,
<video>elements were being processed by the image handler inremarkRehype, causing videos to be treated as images.Video exported as a link in Markdown
When exporting content containing videos to Markdown, the videos were incorrectly serialized as standard link Markdown:
Fixes implemented:
Updated the image handler to detect videos by extension (mp4, webm, etc.) and process them as
<video>elements with the correct attributes: src, data-url, data-name and so on.Added a
convertVideoElementToMarkdownplugin to transform<video>elements into a dedicated video markdown with url and title.#1938