Skip to content

ROUTE-475 Adding WstETHHook and WETHHook to the new hook allowlist #1106

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yucanliu
Copy link
Contributor

@yucanliu yucanliu commented May 6, 2025

Adding WstETHHook and WETHHook to the new hook allowlist

Adding WstETHHook and WETHHook to the new hook allowlist
@yucanliu yucanliu requested a review from jsy1218 May 6, 2025 21:09
@yucanliu yucanliu self-assigned this May 6, 2025
[ChainId.OPTIMISM]: [ADDRESS_ZERO],
[ChainId.OPTIMISM]: [
ADDRESS_ZERO,
WETH_HOOKS_ADDRESS_ON_OP_MAINNET,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsy1218 can you please confirm if OP_MAINNET should be placed under this category?

@graphite-app graphite-app bot requested review from xrsv, cgkol and a team May 6, 2025 21:24
Copy link
Contributor

graphite-app bot commented May 6, 2025

Graphite Automations

"Request reviewers once CI passes on routing-api repo" took an action on this PR • (05/06/25)

4 reviewers were added to this PR based on Siyu Jiang (See-You John)'s automation.

@yucanliu yucanliu force-pushed the yucan-ROUTE-475-allowlist-new-hook branch from 23255ef to 816dfdc Compare May 7, 2025 21:53
@@ -50,6 +50,72 @@ export function v4HooksPoolsFiltering(chainId: ChainId, pools: Array<V4SubgraphP
additionalAllowedPool += 1
}

// MAINNET WETH/ETH
else if (
pool.id.toLowerCase() === '0xf6f2314ac16a878e2bf8ef01ef0a3487e714d397d87f702b9a08603eb3252e92'.toLowerCase() &&
Copy link
Contributor Author

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jsy1218 jsy1218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yucanliu nice work!

let's hold off merging though

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants