-
Notifications
You must be signed in to change notification settings - Fork 213
ROUTE-475 Adding WstETHHook and WETHHook to the new hook allowlist #1106
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
lib/util/hooksAddressesAllowlist.ts
Outdated
[ChainId.OPTIMISM]: [ADDRESS_ZERO], | ||
[ChainId.OPTIMISM]: [ | ||
ADDRESS_ZERO, | ||
WETH_HOOKS_ADDRESS_ON_OP_MAINNET, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsy1218 can you please confirm if OP_MAINNET
should be placed under this category?
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (05/06/25)4 reviewers were added to this PR based on Siyu Jiang (See-You John)'s automation. |
23255ef
to
816dfdc
Compare
@@ -50,6 +50,72 @@ export function v4HooksPoolsFiltering(chainId: ChainId, pools: Array<V4SubgraphP | |||
additionalAllowedPool += 1 | |||
} | |||
|
|||
// MAINNET WETH/ETH | |||
else if ( | |||
pool.id.toLowerCase() === '0xf6f2314ac16a878e2bf8ef01ef0a3487e714d397d87f702b9a08603eb3252e92'.toLowerCase() && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the pool id is extracted from:
mainnet weth<>eth pool: https://etherscan.io/tx/0x0db1d052ce2b8913a78abe91451f2b384a021f531c13d5cc719dd38d5d4cb6c0#eventlog
mainnet wsteth<>steth pool: https://etherscan.io/tx/0xa0f205fdacc7f044bee0637a008bc25f65351f490a2d3ba943dce136d04f4ef9#eventlog
OP eth<>weth https://optimistic.etherscan.io/tx/0x5f81f2aa19a50a76a94a30d3d2a9540cb3cd8597c94499a50330e4b6acbef5c1#eventlog
base eth<>weth https://basescan.org/tx/0x221b6521ee4a19a25a424ecfb36b58b0b68fce7cda106bf4551d1424b0867bcc#eventlog
unichain eth<>weth https://uniscan.xyz/tx/0x935979a7e4a1e3ea92b180009c46242b89a787fb4f2f5799bd53c675d5e0f9fd#eventlog
arbitrum eth<>weth https://arbiscan.io/tx/0x0b393d141a3770292ae8508626a4443307403b0b958b7d0eff70fca2fb85c106#eventlog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For each link, the 1id
is used for the pool id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yucanliu nice work!
let's hold off merging though
Adding WstETHHook and WETHHook to the new hook allowlist