Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BrowserRequests #290

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

XronoZ-create
Copy link

Added new class BrowserRequests. It is planned to add the functionality of the steam site to it.
Added now "get_avatar_url" and "set_avatar"

Added new class BrowserRequests. It is planned to add the functionality of the steam site to it.
Added now "get_avatar_url" and "set_avatar"
@rossengeorgiev
Copy link
Member

I'm not sure the abstraction should be done this way.

Ok, so you have WebAuth (MobileWebAuth basically the same thing), and SteamClient.get_web_session(). Either one provides a requests.Session that is ready to use. Therefore, I think this new abstraction should simply consume that session, and provide methods to interact with say Steam community. Methods such as changing your avatar, or changing profile info on https://steamcommunity.com/my/edit/info

Lets say we call it SteamCommunityClient, which has get/set_avatar methods. Then we use like so:

client = SteamClient()
client.cli_login()
myaccount = SteamCommunityClient(client)
myaccount.set_avatar(path_to_avatarjpg)

or

client = WebClient()
client.cli_login()
myaccount = SteamCommunityClient(client)

In a similar fashion, a SteamStoreClient or a SteamMarketClient could be created.

@XronoZ-create
Copy link
Author

Ok. I will make changes. Thanks 👍

@XronoZ-create
Copy link
Author

Hi 👋
I returned. I plan to introduce methods for working with Steam Community
Look at the abstraction please

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants