Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

upgraded to web api 2.2 and replace msgpack with msgpack.cli #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

joephayes
Copy link

  • upgrade to web api 2.2
  • replaced msgPack with MsPack.Cli

@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Microsoft.AspNet.WebApi.Client" version="4.0.20710.0" targetFramework="net40-Client" />
<package id="Microsoft.Net.Http" version="2.0.20710.0" targetFramework="net40-Client" />
<package id="MsgPack" version="0.1.0.2011042300" targetFramework="net40-Client" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the new version of MsgPack in the packages.config? Can you please make sure to include this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced MsgPack with MsgPack.Cli. The MsgPack package has not been updated since October of 2011 while MsgPack.Cli is under active development.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but I don't see the MsgPack.Cli package in the packages.config.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See commit 91ae605

@panesofglass
Copy link
Member

Thank you for the updates! Please see the questions and comments above.

<package id="MsgPack" version="0.1.0.2011042300" targetFramework="net40-Client" />
<package id="Newtonsoft.Json" version="4.5.11" targetFramework="net40-Client" />
<package id="Microsoft.AspNet.WebApi.Client" version="5.2.3" targetFramework="net45" />
<package id="MsgPack.Cli" version="0.5.10" targetFramework="net45" />
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panesofglass - MsgPack.Cli is added here

@panesofglass panesofglass self-assigned this Feb 26, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants